[sr-dev] git:master:a51a3263: textops: safety check of allocated memory inside append_time_request_f()

Daniel-Constantin Mierla miconda at gmail.com
Tue Mar 21 02:42:00 CET 2017


Module: kamailio
Branch: master
Commit: a51a32633429d761f8bc742386b6f6bcb6b38522
URL: https://github.com/kamailio/kamailio/commit/a51a32633429d761f8bc742386b6f6bcb6b38522

Author: Daniel-Constantin Mierla <miconda at gmail.com>
Committer: Daniel-Constantin Mierla <miconda at gmail.com>
Date: 2017-03-21T02:39:00+01:00

textops: safety check of allocated memory inside append_time_request_f()

- reported by GH #1040

---

Modified: src/modules/textops/textops.c

---

Diff:  https://github.com/kamailio/kamailio/commit/a51a32633429d761f8bc742386b6f6bcb6b38522.diff
Patch: https://github.com/kamailio/kamailio/commit/a51a32633429d761f8bc742386b6f6bcb6b38522.patch

---

diff --git a/src/modules/textops/textops.c b/src/modules/textops/textops.c
index 9338fac..1ebc20d 100644
--- a/src/modules/textops/textops.c
+++ b/src/modules/textops/textops.c
@@ -1214,6 +1214,10 @@ static int append_time_request_f(struct sip_msg* msg, char* p1, char *p2)
 	}
 
 	time_str.s = pkg_malloc(MAX_TIME);
+	if(time_str.s==NULL) {
+		LM_ERR("no more pkg memory\n");
+		goto error;
+	}
 	time_str.len=strftime(time_str.s, MAX_TIME, TIME_FORMAT, bd_time);
 	if (time_str.len>MAX_TIME-2 || time_str.len==0) {
 		LM_ERR("unexpected time length\n");




More information about the sr-dev mailing list