[sr-dev] git:master:42d3b93f: app_perl: Make sv2int_str() static

[James Cloos]

Module: kamailio
Branch: master
Commit: 42d3b93f838d1c2eeb009894422fe016a6572520
URL: https://github.com/kamailio/kamailio/commit/42d3b93f838d1c2eeb009894422fe016a6572520

Author: James Cloos <cloos at jhcloos.com>
Committer: James Cloos <cloos at jhcloos.com>
Date: 2017-03-10T16:52:55-05:00

app_perl: Make sv2int_str() static

- The function is only called from the xs file, and C11’s inline
  semantics mean that gcc-5 and later miscompile this file when
  no optimization is specified.

Signed-off-by: James Cloos <cloos at jhcloos.com>

---

Modified: src/modules/app_perl/kamailioxs.xs

---

Diff:  https://github.com/kamailio/kamailio/commit/42d3b93f838d1c2eeb009894422fe016a6572520.diff
Patch: https://github.com/kamailio/kamailio/commit/42d3b93f838d1c2eeb009894422fe016a6572520.patch

---

diff --git a/src/modules/app_perl/kamailioxs.xs b/src/modules/app_perl/kamailioxs.xs
index 02fb5a5..8d2604c 100644
--- a/src/modules/app_perl/kamailioxs.xs
+++ b/src/modules/app_perl/kamailioxs.xs
@@ -402,7 +402,7 @@ char *pv_sprintf(struct sip_msg *m, char *fmt) {
  * - strflag: flag mask to be or-applied for string match
  */
 
-inline int sv2int_str(SV *val, int_str *is,
+static inline int sv2int_str(SV *val, int_str *is,
 		      unsigned short *flags, unsigned short strflag) {
 	char *s;
 	STRLEN len;