[sr-dev] git:master:5f891d73: db_sqlite: free con in case of error at open time

[Daniel-Constantin Mierla]

Module: kamailio
Branch: master
Commit: 5f891d732443dc065b89b1895601ad429d696c33
URL: https://github.com/kamailio/kamailio/commit/5f891d732443dc065b89b1895601ad429d696c33

Author: Daniel-Constantin Mierla <miconda at gmail.com>
Committer: Daniel-Constantin Mierla <miconda at gmail.com>
Date: 2017-07-15T08:56:04+02:00

db_sqlite: free con in case of error at open time

---

Modified: src/modules/db_sqlite/dbase.c

---

Diff:  https://github.com/kamailio/kamailio/commit/5f891d732443dc065b89b1895601ad429d696c33.diff
Patch: https://github.com/kamailio/kamailio/commit/5f891d732443dc065b89b1895601ad429d696c33.patch

---

diff --git a/src/modules/db_sqlite/dbase.c b/src/modules/db_sqlite/dbase.c
index 3fba0e911b..bba8b01639 100644
--- a/src/modules/db_sqlite/dbase.c
+++ b/src/modules/db_sqlite/dbase.c
@@ -65,7 +65,8 @@ static struct sqlite_connection * db_sqlite_new_connection(const struct db_id* i
 	str db_name = str_init((char *) id->database);
 	db_param_list_t *db_param = db_param_list_search(db_name);
 	if (db_param && db_param->readonly) {
-		// The database is opened in read-only mode. If the database does not already exist, an error is returned.
+		/* The database is opened in read-only mode. If the database does not
+		 * already exist, an error is returned. */
 		flags |= SQLITE_OPEN_READONLY;
 		LM_DBG("[%s] opened with [SQLITE_OPEN_READONLY]\n", id->database);
 	} else {
@@ -93,9 +94,11 @@ static struct sqlite_connection * db_sqlite_new_connection(const struct db_id* i
 				break;
 			} else if (rc != SQLITE_ROW) {
 				LM_ERR("sqlite3_step[%s]\n", sqlite3_errmsg(con->conn));
+				pkg_free(con);
 				return NULL;
 			} else {
 				rc = sqlite3_column_count(stmt);
+				LM_DBG("columns in result: %d\n", rc);
 			}
 		}
 		if (stmt) {