[sr-dev] git:master:2ab0adee: tmx: missing break in t_cancel_branches(others)

Daniel-Constantin Mierla miconda at gmail.com
Tue Jul 4 09:08:45 CEST 2017


Module: kamailio
Branch: master
Commit: 2ab0adee57aa82487adf7d3776835eca071afa27
URL: https://github.com/kamailio/kamailio/commit/2ab0adee57aa82487adf7d3776835eca071afa27

Author: Daniel-Constantin Mierla <miconda at gmail.com>
Committer: Daniel-Constantin Mierla <miconda at gmail.com>
Date: 2017-07-04T09:08:04+02:00

tmx: missing break in t_cancel_branches(others)

---

Modified: src/modules/tmx/tmx_mod.c

---

Diff:  https://github.com/kamailio/kamailio/commit/2ab0adee57aa82487adf7d3776835eca071afa27.diff
Patch: https://github.com/kamailio/kamailio/commit/2ab0adee57aa82487adf7d3776835eca071afa27.patch

---

diff --git a/src/modules/tmx/tmx_mod.c b/src/modules/tmx/tmx_mod.c
index 19a8962813..9c5f8b1042 100644
--- a/src/modules/tmx/tmx_mod.c
+++ b/src/modules/tmx/tmx_mod.c
@@ -322,15 +322,18 @@ static int t_cancel_branches(struct sip_msg* msg, char *k, char *s2)
 	init_cancel_info(&cancel_data);
 	switch(n) {
 		case 1:
-			/* prepare cancel for every branch except idx */
+			/* prepare cancel for every branch except idx (others) */
 			_tmx_tmb.prepare_to_cancel(t,
 					&cancel_data.cancel_bitmap, 1<<idx);
+			break;
 		case 2:
+			/* prepare cancel for current branch (idx) */
 			if(msg->first_line.u.reply.statuscode>=200)
 				break;
 			cancel_data.cancel_bitmap = 1<<idx;
 			break;
 		default:
+			/* prepare cancel for all branches */
 			if (msg->first_line.u.reply.statuscode>=200)
 				/* prepare cancel for every branch except idx */
 				_tmx_tmb.prepare_to_cancel(t,




More information about the sr-dev mailing list