[sr-dev] git:master:59bab1e0: ims_icscf: fix compiler warnings

Victor Seva linuxmaniac at torreviejawireless.org
Tue Jan 17 10:22:12 CET 2017


Module: kamailio
Branch: master
Commit: 59bab1e0df3042cab346022efcba3520d1382c91
URL: https://github.com/kamailio/kamailio/commit/59bab1e0df3042cab346022efcba3520d1382c91

Author: Victor Seva <linuxmaniac at torreviejawireless.org>
Committer: Victor Seva <linuxmaniac at torreviejawireless.org>
Date: 2017-01-17T10:22:05+01:00

ims_icscf: fix compiler warnings

> In file included from registration.h:49:0,
>                  from mod.h:68,
>                  from cxdx_lir.c:51:
> scscf_list.h:141:13: warning: inline function 'i_unlock' declared but never defined
>  inline void i_unlock(unsigned int hash);
>              ^~~~~~~~
> scscf_list.h:140:13: warning: inline function 'i_lock' declared but never defined
>  inline void i_lock(unsigned int hash);
>              ^~~~~~
> scscf_list.h:139:21: warning: inline function 'get_call_id_hash' declared but never defined
>  inline unsigned int get_call_id_hash(str callid,int hash_size);
>                      ^~~~~~~~~~~~~~~~

---

Modified: src/modules/ims_icscf/scscf_list.c
Modified: src/modules/ims_icscf/scscf_list.h

---

Diff:  https://github.com/kamailio/kamailio/commit/59bab1e0df3042cab346022efcba3520d1382c91.diff
Patch: https://github.com/kamailio/kamailio/commit/59bab1e0df3042cab346022efcba3520d1382c91.patch

---

diff --git a/src/modules/ims_icscf/scscf_list.c b/src/modules/ims_icscf/scscf_list.c
index 3634285..f6ebbb5 100644
--- a/src/modules/ims_icscf/scscf_list.c
+++ b/src/modules/ims_icscf/scscf_list.c
@@ -285,7 +285,7 @@ int add_scscf_list(str call_id, scscf_entry *sl) {
 /**
  * Computes the hash for a string.
  */
-inline unsigned int get_call_id_hash(str callid, int hash_size) {
+unsigned int get_call_id_hash(str callid, int hash_size) {
 #define h_inc h+=v^(v>>3)
     char* p;
     register unsigned v;
@@ -334,7 +334,7 @@ scscf_list* new_scscf_list(str call_id, scscf_entry *sl) {
 /**
  * Locks the required part of hash with S-CSCF lists
  */
-inline void i_lock(unsigned int hash) {
+void i_lock(unsigned int hash) {
 
     lock_get(i_hash_table[(hash)].lock);
 
@@ -343,7 +343,7 @@ inline void i_lock(unsigned int hash) {
 /**
  * UnLocks the required part of hash with S-CSCF lists
  */
-inline void i_unlock(unsigned int hash) {
+void i_unlock(unsigned int hash) {
     lock_release(i_hash_table[(hash)].lock);
 
 }
diff --git a/src/modules/ims_icscf/scscf_list.h b/src/modules/ims_icscf/scscf_list.h
index 107e599..2150b75 100644
--- a/src/modules/ims_icscf/scscf_list.h
+++ b/src/modules/ims_icscf/scscf_list.h
@@ -136,9 +136,9 @@ int I_get_capabilities();
 int I_get_capab_match(scscf_capabilities *c,int *m,int mcnt,int *o,int ocnt);
 int add_scscf_list(str call_id,scscf_entry *sl);
 scscf_list* new_scscf_list(str call_id,scscf_entry *sl);
-inline unsigned int get_call_id_hash(str callid,int hash_size);
-inline void i_lock(unsigned int hash);
-inline void i_unlock(unsigned int hash);
+unsigned int get_call_id_hash(str callid,int hash_size);
+void i_lock(unsigned int hash);
+void i_unlock(unsigned int hash);
 int I_scscf_select(struct sip_msg* msg, char* str1, char* str2);
 
 /**




More information about the sr-dev mailing list