[sr-dev] git:master:49fa527a: ims_icscf: fix compiler warnings

Victor Seva linuxmaniac at torreviejawireless.org
Mon Jan 16 10:08:04 CET 2017


Module: kamailio
Branch: master
Commit: 49fa527af4028904a13122517b61a6535837c4b6
URL: https://github.com/kamailio/kamailio/commit/49fa527af4028904a13122517b61a6535837c4b6

Author: Victor Seva <linuxmaniac at torreviejawireless.org>
Committer: Victor Seva <linuxmaniac at torreviejawireless.org>
Date: 2017-01-16T10:06:29+01:00

ims_icscf: fix compiler warnings

> cxdx_avp.c: In function 'cxdx_get_auth_data_item_answer':
> cxdx_avp.c:625:26: warning: comparison of constant '4' with boolean expression is always false [-Wbool-compare]
>   if (!avp||!avp->data.len==4) *item_number=0;
>                           ^~
> cxdx_avp.c:625:26: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]

---

Modified: src/modules/ims_icscf/cxdx_avp.c

---

Diff:  https://github.com/kamailio/kamailio/commit/49fa527af4028904a13122517b61a6535837c4b6.diff
Patch: https://github.com/kamailio/kamailio/commit/49fa527af4028904a13122517b61a6535837c4b6.patch

---

diff --git a/src/modules/ims_icscf/cxdx_avp.c b/src/modules/ims_icscf/cxdx_avp.c
index 8d833b7..7dbcc36 100644
--- a/src/modules/ims_icscf/cxdx_avp.c
+++ b/src/modules/ims_icscf/cxdx_avp.c
@@ -622,7 +622,7 @@ int cxdx_get_auth_data_item_answer(AAAMessage *msg, AAA_AVP **auth_data,
 
 	avp = cdpb.AAAFindMatchingAVPList(list,0,AVP_IMS_SIP_Item_Number,
 		IMS_vendor_id_3GPP,0);
-	if (!avp||!avp->data.len==4) *item_number=0;
+	if (!avp||avp->data.len!=4) *item_number=0;
 	else *item_number = get_4bytes(avp->data.s);
 
 	avp = cdpb.AAAFindMatchingAVPList(list,0,AVP_IMS_SIP_Authentication_Scheme,




More information about the sr-dev mailing list