[sr-dev] [kamailio/kamailio] registrar: save() returns separate code on 503 generation (#928)

Lucian Balaceanu notifications at github.com
Fri Jan 13 11:35:05 CET 2017


We would like to know when the save("location") has generated a 503 message and as such we are thinking of modifying the save() function to return a code (like -2) for this error.

The default behaviour now seems to be that most errors in save() log a notice message, generate a reply via reg_send_reply() and then make sure that config doesn't go on with processing by returning 0. (tag "error:" in save() function definition)

Are you ok with such an intrusion in the code? 

Thank you

Also, do you see an alternative to determining that this 503 message has been generated?

You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/928

-- Commit Summary --

  * registrar: save() returns separate code on 503 generation

-- File Changes --

    M src/modules/registrar/save.c (4)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/928.patch
https://github.com/kamailio/kamailio/pull/928.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/928
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20170113/80b10234/attachment.html>


More information about the sr-dev mailing list