[sr-dev] [kamailio/kamailio] dmq_usrloc: fix deadlock (#911)

[Daniel-Constantin Mierla]

miconda commented on this pull request.



> @@ -72,6 +70,7 @@ static int add_contact(str aor, ucontact_info_t* ci)
 		// Search by ruid, if possible
 		res = dmq_ul.get_urecord_by_ruid(_d, dmq_ul.get_aorhash(&aor), &ci->ruid, &r, &c);
 		if (res == 0) {
+			dmq_ul.lock_udomain(_d, &aor);

This addition to line 73 doesn't seem necessary, because the lock is aquired by get_urecord_by_ruid(). Or did I miss something?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/911#pullrequestreview-15258004
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20170104/0220414a/attachment.html>