[sr-dev] [kamailio/kamailio] rtpengine: really do allow unsigned setid (#999)

[Richard Fuchs]

rfuchs requested changes on this pull request.

There's a few mismatches between signed and unsigned left, but I think they can be resolved only up to a certain point, as Kamailio doesn't have support for unsigned types in certain areas

>  			pkg_free(*param);
-			if((rtpp_list = select_rtpp_set(int_val)) ==0){
-				LM_ERR("rtpp_proxy set %i not configured\n", int_val);
+			if((rtpp_list = select_rtpp_set(set_id)) ==0){
+				LM_ERR("rtpp_proxy set %i not configured\n", set_id);

format should be %u here

> @@ -1442,9 +1443,9 @@ mod_init(void)
 	/* select the default set */
 	default_rtpp_set = select_rtpp_set(setid_default);
 	if (!default_rtpp_set) {
-		LM_NOTICE("Default rtpp set %d NOT found\n", setid_default);
+		LM_NOTICE("Default rtpp set %u NOT found\n", setid_default);

The type of `setid_default` itself also ought to be changed to unsigned accordingly

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/999#pullrequestreview-22966081
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20170221/30d0d63b/attachment.html>