[sr-dev] git:master:37f6e1e7: call_control: keep reference to allocated buffer used for params

[Daniel-Constantin Mierla]

Module: kamailio
Branch: master
Commit: 37f6e1e7640b29263e85be9e8958ee14912e20a1
URL: https://github.com/kamailio/kamailio/commit/37f6e1e7640b29263e85be9e8958ee14912e20a1

Author: Daniel-Constantin Mierla <miconda at gmail.com>
Committer: Daniel-Constantin Mierla <miconda at gmail.com>
Date: 2017-12-20T09:36:54+01:00

call_control: keep reference to allocated buffer used for params

---

Modified: src/modules/call_control/call_control.c

---

Diff:  https://github.com/kamailio/kamailio/commit/37f6e1e7640b29263e85be9e8958ee14912e20a1.diff
Patch: https://github.com/kamailio/kamailio/commit/37f6e1e7640b29263e85be9e8958ee14912e20a1.patch

---

diff --git a/src/modules/call_control/call_control.c b/src/modules/call_control/call_control.c
index 689a16d1fd..78b892087f 100644
--- a/src/modules/call_control/call_control.c
+++ b/src/modules/call_control/call_control.c
@@ -91,6 +91,7 @@ typedef struct AVP_Param {
 typedef struct AVP_List {
     pv_spec_p pv;
     str name;
+    char *orig;
     struct AVP_List *next;
 } AVP_List;
 
@@ -261,6 +262,7 @@ cc_parse_param(void *val, AVP_List** avps) {
 
     p0 = (char*) pkg_malloc (content.len + 1);
     CHECK_ALLOC(p0);
+    memset(p0, 0, content.len + 1);
     p = p0;
 
     p[content.len] = '\0';
@@ -270,9 +272,11 @@ cc_parse_param(void *val, AVP_List** avps) {
 
         mp = (AVP_List*) pkg_malloc (sizeof(AVP_List));
         CHECK_ALLOC(mp);
+        memset(mp, 0, sizeof(AVP_List));
         mp->next = *avps;
         mp->pv = (pv_spec_p) pkg_malloc (sizeof(pv_spec_t));
         CHECK_ALLOC(mp->pv);
+        memset(mp->pv, 0, sizeof(pv_spec_t));
 
         for (; isspace(*p); p++);
         CHECK_COND(*p != '\0');
@@ -307,6 +311,12 @@ cc_parse_param(void *val, AVP_List** avps) {
         *avps = mp;
     }
 
+    if(mp==0) {
+        pkg_free(p0);
+    } else {
+        mp->orig = p0;
+    }
+
     return 0;
 
 error: