[sr-dev] [kamailio/kamailio] TOPOH module mask_ip errantly skips decoding encoded fields (#1222)

[Joshua Riffle]

Hi @miconda I just read through some of the history on this issue and see you have been adding commits around this issue from before June 25th. The other issue I saw #1165 appears to be the same problem. Couldn't we get around this issue by simply adding ":5060" to the after the ip when the th_uri_prefix is generated? If it is added with the port into the SIP message then I feel like it would be safe to assume the carriers will not try to modify the URI and screw up the prefix thus allowing you to keep your URI prefix safety checks by default. Any thoughts?

I believe the changes you made to 4.4 should fix my issue. I created a small temporary patch myself and I will be testing shortly by just appending ":5060" to the uri prefix to see if I can validate my thoughts.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1222#issuecomment-326025513
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20170830/eaf8e987/attachment-0001.html>