[sr-dev] git:master:b5bccd0f: db_text: missing breaks in checking db types compatibility

Daniel-Constantin Mierla miconda at gmail.com
Thu Aug 3 05:29:00 CEST 2017


Module: kamailio
Branch: master
Commit: b5bccd0f4e14909b4a0ba2ab3957b2ea9b28ed0c
URL: https://github.com/kamailio/kamailio/commit/b5bccd0f4e14909b4a0ba2ab3957b2ea9b28ed0c

Author: Daniel-Constantin Mierla <miconda at gmail.com>
Committer: Daniel-Constantin Mierla <miconda at gmail.com>
Date: 2017-08-03T05:03:24+02:00

db_text: missing breaks in checking db types compatibility

---

Modified: src/modules/db_text/dbt_lib.c

---

Diff:  https://github.com/kamailio/kamailio/commit/b5bccd0f4e14909b4a0ba2ab3957b2ea9b28ed0c.diff
Patch: https://github.com/kamailio/kamailio/commit/b5bccd0f4e14909b4a0ba2ab3957b2ea9b28ed0c.patch

---

diff --git a/src/modules/db_text/dbt_lib.c b/src/modules/db_text/dbt_lib.c
index 3a1ec79eb8..0735c04c2e 100644
--- a/src/modules/db_text/dbt_lib.c
+++ b/src/modules/db_text/dbt_lib.c
@@ -442,30 +442,34 @@ int dbt_is_neq_type(db_type_t _t0, db_type_t _t1)
 		case DB1_INT:
 			if(_t0==DB1_DATETIME || _t0==DB1_BITMAP)
 				return 0;
-
+			break;
 		case DB1_BIGINT:
 			LM_ERR("BIGINT not supported\n");
 			return 0;
-
 		case DB1_DATETIME:
 			if(_t0==DB1_INT)
 				return 0;
 			if(_t0==DB1_BITMAP)
 				return 0;
+			break;
 		case DB1_DOUBLE:
 			break;
 		case DB1_STRING:
 			if(_t0==DB1_STR || _t0==DB1_BLOB)
 				return 0;
+			break;
 		case DB1_STR:
 			if(_t0==DB1_STRING || _t0==DB1_BLOB)
 				return 0;
+			break;
 		case DB1_BLOB:
 			if(_t0==DB1_STR || _t0==DB1_STRING)
 				return 0;
+			break;
 		case DB1_BITMAP:
 			if (_t0==DB1_INT)
 				return 0;
+			break;
 		default:
 			LM_ERR("invalid datatype %d\n", _t1);
 			return 1;
@@ -483,7 +487,6 @@ dbt_table_p dbt_db_get_temp_table(dbt_cache_p _dc)
 	int hash;
 	int hashidx;
 
-
 	if(!_dbt_cachetbl || !_dc) {
 		LM_ERR("invalid parameter\n");
 		return NULL;
@@ -500,8 +503,6 @@ dbt_table_p dbt_db_get_temp_table(dbt_cache_p _dc)
 
 	_tbc = _dbt_cachetbl[hashidx].dtp;
 
-
-
 	_tbc = dbt_table_new(&_s, &(_dc->name), NULL);
 
 	_tbc->hash = hash;
@@ -513,7 +514,6 @@ dbt_table_p dbt_db_get_temp_table(dbt_cache_p _dc)
 
 	dbt_table_update_flags(_tbc, DBT_TBFL_TEMP, DBT_FL_SET, 0);
 
-
 	lock_release(&_dbt_cachetbl[hashidx].sem);
 	return _tbc;
 }




More information about the sr-dev mailing list