[sr-dev] git:5.0:4ad64c0f: db_text: add db_delim parameter

[Daniel-Constantin Mierla]

Hello,

nothing to be really sorry about, we collaborate here and it is the role
of github to make it easy to revert.

I think it is good to revert to keep it clean, as we build packages over
the night and some people are using them.

If this is something that solve some problems for you, then you can
write an email to sr-dev or even better make a pull request to backport
this patch and let the others comment there to take a decision.

Cheers,
Daniel


On 24.04.17 16:52, Lucian Balaceanu wrote:
> Hello Daniel,
>
> I am sorry for this situation; do I revert the commit?
>
> Thank you,
> Lucian
>
> On 24.04.2017 17:41, Daniel-Constantin Mierla wrote:
>> Hello,
>>
>> the rule is not to backport new features to stable versions, because we
>> will end up in a mixture of untested code where stability cannot be
>> ensured.
>>
>> I don't feel that this commit is fixing an existing issues, rather
>> making it more aesthetic in some cases.
>>
>> If I got it wrong, please provide more details and if other developers
>> are fine with this backport, I won't be against it.
>>
>> Cheers,
>> Daniel
>>
>> On 24.04.17 16:36, Lucian Balaceanu wrote:
>>> Module: kamailio
>>> Branch: 5.0
>>> Commit: 4ad64c0ff0384b232b7c198316b46a86ad2c4f31
>>> URL:
>>> https://github.com/kamailio/kamailio/commit/4ad64c0ff0384b232b7c198316b46a86ad2c4f31
>>>
>>> Author: Lucian Balaceanu <lucian.balaceanu at 1and1.ro>
>>> Committer: Lucian Balaceanu <lucian.balaceanu at 1and1.ro>
>>> Date: 2017-04-24T17:31:45+03:00
>>>
>>> db_text: add db_delim parameter
>>>
>>> - make the delimiter between fields in th db_text file configurable;
>>>    useful when one would need to escape a lot of appearances of the
>>>    default delimiter (';' in IPv6 addresses).
>>>
>>> ---
>>>
>>> Modified: src/modules/db_text/db_text.c
>>> Modified: src/modules/db_text/dbt_file.c
>>> Modified: src/modules/db_text/dbt_lib.h
>>> Modified: src/modules/db_text/doc/db_text_admin.xml
>>>
>>> ---
>>>
>>> Diff: 
>>> https://github.com/kamailio/kamailio/commit/4ad64c0ff0384b232b7c198316b46a86ad2c4f31.diff
>>> Patch:
>>> https://github.com/kamailio/kamailio/commit/4ad64c0ff0384b232b7c198316b46a86ad2c4f31.patch
>>>
>>>
>>> _______________________________________________
>>> Kamailio (SER) - Development Mailing List
>>> sr-dev at lists.kamailio.org
>>> https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
>

-- 
Daniel-Constantin Mierla
www.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio Advanced Training - May 22-24 (USA) - www.asipto.com
Kamailio World Conference - May 8-10, 2017 - www.kamailioworld.com