[sr-dev] [kamailio/kamailio] modules/ims_auth, modules/ims_registrar_scscf: fix condition for priv… (#818)

[Federico Cabiddu]

…ate copy of the msg

I've been facing recently some inconsistent replies generated from the two modules. Those replies didn't belong to the current request, but to some old transaction. The issue is due to the check made to decide if the current private copy of the message is consistent with the current transaction: due to memory reallocation there are chances that the check gives a false negative, bringing an old message to be used as a base for the reply. Using transaction's index and label is safer IMO.
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/818

-- Commit Summary --

  * modules/ims_auth, modules/ims_registrar_scscf: fix condition for private copy of the msg

-- File Changes --

    M modules/ims_auth/pvt_message.c (13)
    M modules/ims_auth/pvt_message.h (5)
    M modules/ims_registrar_scscf/pvt_message.c (15)
    M modules/ims_registrar_scscf/pvt_message.h (5)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/818.patch
https://github.com/kamailio/kamailio/pull/818.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/818
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20161009/671dbaf9/attachment.html>