[sr-dev] git:master:819442ab: cdp: remove inline for functions exported via header files

Daniel-Constantin Mierla miconda at gmail.com
Thu May 5 10:03:07 CEST 2016


Module: kamailio
Branch: master
Commit: 819442ab3d768a60574f6de69cab5657d4075a46
URL: https://github.com/kamailio/kamailio/commit/819442ab3d768a60574f6de69cab5657d4075a46

Author: Daniel-Constantin Mierla <miconda at gmail.com>
Committer: Daniel-Constantin Mierla <miconda at gmail.com>
Date: 2016-05-05T09:57:44+02:00

cdp: remove inline for functions exported via header files

- fix clang compile warnings

---

Modified: modules/cdp/acctstatemachine.c
Modified: modules/cdp/acctstatemachine.h
Modified: modules/cdp/config.c
Modified: modules/cdp/config.h

---

Diff:  https://github.com/kamailio/kamailio/commit/819442ab3d768a60574f6de69cab5657d4075a46.diff
Patch: https://github.com/kamailio/kamailio/commit/819442ab3d768a60574f6de69cab5657d4075a46.patch

---

diff --git a/modules/cdp/acctstatemachine.c b/modules/cdp/acctstatemachine.c
index 80901b1..777971d 100644
--- a/modules/cdp/acctstatemachine.c
+++ b/modules/cdp/acctstatemachine.c
@@ -12,7 +12,7 @@
 /**
  * update Granted Service Unit timers based on CCR
  */
-inline void update_gsu_request_timers(cdp_cc_acc_session_t* session, AAAMessage* msg) {
+void update_gsu_request_timers(cdp_cc_acc_session_t* session, AAAMessage* msg) {
 	AAA_AVP *avp;
 
 	avp = AAAFindMatchingAVP(msg, 0, AVP_Event_Timestamp, 0, 0);
@@ -24,7 +24,7 @@ inline void update_gsu_request_timers(cdp_cc_acc_session_t* session, AAAMessage*
 /**
  * update Granted Service Unit timers based on CCA, for onw we assume on one MSCC per session and only TIME based supported
  */
-inline void update_gsu_response_timers(cdp_cc_acc_session_t* session, AAAMessage* msg) {
+void update_gsu_response_timers(cdp_cc_acc_session_t* session, AAAMessage* msg) {
 	AAA_AVP *avp;
 	AAA_AVP_LIST mscc_avp_list;
 	AAA_AVP_LIST y;
@@ -89,7 +89,7 @@ inline void update_gsu_response_timers(cdp_cc_acc_session_t* session, AAAMessage
  * @param msg  - AAAMessage
  * @returns 0 if msg should be given to the upper layer 1 if not
  */
-inline int cc_acc_client_stateful_sm_process(cdp_session_t* s, int event, AAAMessage* msg)
+int cc_acc_client_stateful_sm_process(cdp_session_t* s, int event, AAAMessage* msg)
 {
 	cdp_cc_acc_session_t* x;
 	int ret = 0;
diff --git a/modules/cdp/acctstatemachine.h b/modules/cdp/acctstatemachine.h
index 129aaa8..c39da48 100644
--- a/modules/cdp/acctstatemachine.h
+++ b/modules/cdp/acctstatemachine.h
@@ -14,6 +14,6 @@
 
 #define EPOCH_UNIX_TO_EPOCH_NTP 2208988800u // according to http://www.cis.udel.edu/~mills/y2k.html
 
-inline int cc_acc_client_stateful_sm_process(cdp_session_t* cc_acc, int event, AAAMessage* msg);
+int cc_acc_client_stateful_sm_process(cdp_session_t* cc_acc, int event, AAAMessage* msg);
 
 #endif /* ACCTSTATEMACHINE_H_ */
diff --git a/modules/cdp/config.c b/modules/cdp/config.c
index e4841b6..9bc25d7 100644
--- a/modules/cdp/config.c
+++ b/modules/cdp/config.c
@@ -173,7 +173,7 @@ inline void free_dp_config(dp_config *x)
 /**
  * Log the dp_config to output, for debug purposes.
  */
-inline void log_dp_config(dp_config *x)
+void log_dp_config(dp_config *x)
 {
 	int i;
 	LM_DBG("Diameter Peer Config:\n");
diff --git a/modules/cdp/config.h b/modules/cdp/config.h
index 422d92e..ed4e0fe 100644
--- a/modules/cdp/config.h
+++ b/modules/cdp/config.h
@@ -139,7 +139,7 @@ routing_entry *new_routing_entry();
 void free_dp_config(dp_config *x);
 void free_routing_realm(routing_realm *rr);
 void free_routing_entry(routing_entry *re);
-inline void log_dp_config(dp_config *x);
+void log_dp_config(dp_config *x);
 
 xmlDocPtr parse_dp_config_file(char* filename);
 xmlDocPtr parse_dp_config_str(str config_str);




More information about the sr-dev mailing list