[sr-dev] [kamailio/kamailio] a single digit is a valid enum_query() request (#594)

Daniel-Constantin Mierla notifications at github.com
Mon May 2 16:28:59 CEST 2016


As a matter of fact, even the current version of allowing 2 digits is probably not an e164 number. The only country code that is one digit is US/Canada with '1', but then there is no real number in their numbering plan with just a single digit after the country code.

The patch for the code is to a part where it checks that the length is sufficient to be sure that accessing the char at position 0 (first char) is safe and it is '+'. Because after that is a FOR loop starting at positing 1 (second char) to see if there are digits.

It might be useful to add min/max_length restrictions, but is more or less not related to this patch (or better said, not only related to this part). That could be an enhancement.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/594#issuecomment-216250402
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20160502/78d30543/attachment.html>


More information about the sr-dev mailing list