[sr-dev] [kamailio/kamailio] utils: introduced the ability to add User-Agent header in HTTP requests. (#670)

Daniel-Constantin Mierla notifications at github.com
Tue Jun 14 16:25:25 CEST 2016


@sipidronov good catch, indeed. It should be user_agent.s and only set if the user_agent.len>0. Even in the current form works because .s is the firs field in the str structure, that is not safe for future.

I also think the variable and parameter should be prefixed with http_, as those related to the http query of utils are (e.g., timeout), to be more clear that it refers to the http functionality from the module.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/670#issuecomment-225897805
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20160614/ec06e1e4/attachment.html>


More information about the sr-dev mailing list