[sr-dev] [kamailio/kamailio] Fix check_route_param() (#663)

Dragos Oancea notifications at github.com
Tue Jun 7 14:54:30 CEST 2016


Given that there are multiple Route sets , each with one param , check_route_param() function fails to search the proper param.s string . 
The condition params.s[0]!=';'  holds false and it stops the loop only when it encounters another ";" character which is not part of the Route header .

Eg: (these are not actual Route params, but this is what it is printing instead - this is part of my INVITE, and these headers are above Route ):
rr [loose.c:985]: check_route_param(): params are <;spi-s=424238335#015#012Require: sec-agree#015#012Proxy-Require: sec-agree#015#012Cont>

This patch is a functional workaround. 
Note I have also seen there routed_params.s not pointing to the actual params , so perhaps there might be another issue before reaching this code.   


You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/663

-- Commit Summary --

  * rr: fix Route param search in check_route_param()
  * Merge remote-tracking branch 'upstream/master' into fix-check_route_param

-- File Changes --

    M modules/rr/loose.c (4)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/663.patch
https://github.com/kamailio/kamailio/pull/663.diff

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/663
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20160607/73406d6c/attachment-0001.html>


More information about the sr-dev mailing list