[sr-dev] git:master:4fa83825: ims_dialog: fix compilation warning

[Victor Seva]

Module: kamailio
Branch: master
Commit: 4fa83825c7bd51d59d9788c6fd7dd532b5bce398
URL: https://github.com/kamailio/kamailio/commit/4fa83825c7bd51d59d9788c6fd7dd532b5bce398

Author: Victor Seva <linuxmaniac at torreviejawireless.org>
Committer: Victor Seva <linuxmaniac at torreviejawireless.org>
Date: 2016-06-06T12:05:39+02:00

ims_dialog: fix compilation warning

> dlg_handlers.c:1345:63: warning: address of 'rpl->via1->branch->value' will always evaluate to 'true' [-Wpointer-bool-conversion]
>                 if (rpl->via1->branch && (&rpl->via1->branch->value) && (rpl->via1->branch->value.len > 0)) {
>                                       ~~   ~~~~~~~~~~~~~~~~~~~^~~~~
> 1 warning generated.

---

Modified: modules/ims_dialog/dlg_handlers.c

---

Diff:  https://github.com/kamailio/kamailio/commit/4fa83825c7bd51d59d9788c6fd7dd532b5bce398.diff
Patch: https://github.com/kamailio/kamailio/commit/4fa83825c7bd51d59d9788c6fd7dd532b5bce398.patch

---

diff --git a/modules/ims_dialog/dlg_handlers.c b/modules/ims_dialog/dlg_handlers.c
index 394c779..faf7678 100644
--- a/modules/ims_dialog/dlg_handlers.c
+++ b/modules/ims_dialog/dlg_handlers.c
@@ -1342,7 +1342,7 @@ void dlg_onreply(struct cell* t, int type, struct tmcb_params *param) {
 
         if (!dlg_out) {
             if (rpl->first_line.u.reply.statuscode < 299) { /*we don't care about failure responses to dialog - not necessary to create dialog out...*/
-                if (rpl->via1->branch && (&rpl->via1->branch->value) && (rpl->via1->branch->value.len > 0)) {
+                if (rpl->via1->branch && (rpl->via1->branch->value.len > 0)) {
                     branch = rpl->via1->branch->value;
                 }