[sr-dev] git:master:bb545d02: peering: fix compilation warning

Victor Seva linuxmaniac at torreviejawireless.org
Tue Jun 7 12:19:49 CEST 2016


Module: kamailio
Branch: master
Commit: bb545d02225f23e7d1d9c950f2e4645db3d33c4f
URL: https://github.com/kamailio/kamailio/commit/bb545d02225f23e7d1d9c950f2e4645db3d33c4f

Author: Victor Seva <linuxmaniac at torreviejawireless.org>
Committer: Victor Seva <linuxmaniac at torreviejawireless.org>
Date: 2016-06-06T12:05:39+02:00

peering: fix compilation warning

> verify.c:58:30: warning: comparison of array 'vp->strvalue' equal to a null pointer is always false [-Wtautological-pointer-compare]
>     if (vp->lvalue==0 || vp->strvalue==0)
>                          ~~~~^~~~~~~~  ~
> 1 warning generated.

---

Modified: modules/peering/verify.c

---

Diff:  https://github.com/kamailio/kamailio/commit/bb545d02225f23e7d1d9c950f2e4645db3d33c4f.diff
Patch: https://github.com/kamailio/kamailio/commit/bb545d02225f23e7d1d9c950f2e4645db3d33c4f.patch

---

diff --git a/modules/peering/verify.c b/modules/peering/verify.c
index cafd12c..743fcfe 100644
--- a/modules/peering/verify.c
+++ b/modules/peering/verify.c
@@ -55,7 +55,7 @@ static inline int extract_avp(VALUE_PAIR* vp, unsigned short *flags,
     char *end;
 
     /* empty? */
-    if (vp->lvalue==0 || vp->strvalue==0)
+    if (vp->lvalue==0)
         goto error;
 
     p = vp->strvalue;




More information about the sr-dev mailing list