[sr-dev] git:master:af9d176e: modules/ims_qos, modules/ims_registrar_scscf: cast 0 to U for unsigned comparisions

jaybeepee jason.penton at gmail.com
Mon Jun 6 11:46:46 CEST 2016


Module: kamailio
Branch: master
Commit: af9d176e1e6760c390b6ba951843afc1872ec437
URL: https://github.com/kamailio/kamailio/commit/af9d176e1e6760c390b6ba951843afc1872ec437

Author: jaybeepee <jason.penton at gmail.com>
Committer: jaybeepee <jason.penton at gmail.com>
Date: 2016-06-06T11:46:35+02:00

modules/ims_qos, modules/ims_registrar_scscf: cast 0 to U for unsigned comparisions
		- strict compiler silencing

---

Modified: modules/ims_qos/rx_avp.c
Modified: modules/ims_registrar_scscf/save.c

---

Diff:  https://github.com/kamailio/kamailio/commit/af9d176e1e6760c390b6ba951843afc1872ec437.diff
Patch: https://github.com/kamailio/kamailio/commit/af9d176e1e6760c390b6ba951843afc1872ec437.patch

---

diff --git a/modules/ims_qos/rx_avp.c b/modules/ims_qos/rx_avp.c
index 657716c..2757bad 100644
--- a/modules/ims_qos/rx_avp.c
+++ b/modules/ims_qos/rx_avp.c
@@ -489,7 +489,7 @@ inline int rx_add_media_component_description_avp(AAAMessage *msg, int number, s
 	// Get A=RS-bandwidth from SDP-Reply:
         bandwidth = sdp_b_value(rpl_raw_payload, "RS");
         LM_DBG("Answer: Got bandwidth %i from b=RS-Line\n", bandwidth);
-	if (bandwidth >= 0) {
+	if (bandwidth >= 0U) {
 		// Add AVP
 		set_4bytes(x,bandwidth);
 		rs_bw = cdpb.AAACreateAVP(AVP_EPC_RS_Bandwidth,
@@ -501,7 +501,7 @@ inline int rx_add_media_component_description_avp(AAAMessage *msg, int number, s
 	// Get A=RS-bandwidth from SDP-Reply:
         bandwidth = sdp_b_value(rpl_raw_payload, "RR");
         LM_DBG("Answer: Got bandwidth %i from b=RR-Line\n", bandwidth);
-	if (bandwidth >= 0) {
+	if (bandwidth >= 0U) {
 		// Add AVP
 		set_4bytes(x,bandwidth);
 		rr_bw = cdpb.AAACreateAVP(AVP_EPC_RR_Bandwidth,
diff --git a/modules/ims_registrar_scscf/save.c b/modules/ims_registrar_scscf/save.c
index 7649bce..4d7707a 100644
--- a/modules/ims_registrar_scscf/save.c
+++ b/modules/ims_registrar_scscf/save.c
@@ -111,7 +111,7 @@ static inline int randomize_expires(int expires, int range) {
 static inline int calc_contact_expires(contact_t *c, unsigned int expires_hdr, int sos_reg) {
     unsigned int r;
 
-    if (expires_hdr >= 0)
+    if (expires_hdr >= 0U)
         r = expires_hdr;
     else {
         r = (sos_reg > 0) ? default_registrar_cfg.em_default_expires : default_registrar_cfg.default_expires;




More information about the sr-dev mailing list