[sr-dev] [kamailio/kamailio] presence: add new parameter `subscribe_expires_offset` (#654)

[lazedo]

@eschmidbauer please read the code related to presence timers, they make the select with the expires_offset. the change that you're proposing, it seems to me, that will have the side effect on NOTIFY messages of sending the wrong remaining period in the subscription, if the UA takes the value from the NOTIFY then you will end up with the same problem again.

if you think that you found that expires_offset has no affect on SUBSCRIBE requests, please show us where. i see it being used in `update_db_subs_timer_notifier` , `update_db_subs_timer_dbonly`, `update_db_subs_timer_dbnone`, `update_db_subs_timer`. current_time is deducted the expires_offsite and gets subscription LT that value. check here [here](https://github.com/kamailio/kamailio/blob/b0a0b3dd12b1c218fffae75b9da7d454d1a39486/modules/presence/subscribe.c#L1945-L1946)

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/654#issuecomment-223843584
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20160605/44b9d4f6/attachment-0001.html>