[sr-dev] git:master:5e826dd1: Makefile.defs: remove outdated OpenBSD logic

Mikko Lehto mslehto at iki.fi
Mon Feb 22 23:17:53 CET 2016


Module: kamailio
Branch: master
Commit: 5e826dd14f0f7035aaec534351d1634f65f2be36
URL: https://github.com/kamailio/kamailio/commit/5e826dd14f0f7035aaec534351d1634f65f2be36

Author: Mikko Lehto <mslehto at iki.fi>
Committer: Mikko Lehto <mslehto at iki.fi>
Date: 2016-02-22T23:45:38+02:00

Makefile.defs: remove outdated OpenBSD logic

---

Modified: Makefile.defs
Modified: sr_module.c

---

Diff:  https://github.com/kamailio/kamailio/commit/5e826dd14f0f7035aaec534351d1634f65f2be36.diff
Patch: https://github.com/kamailio/kamailio/commit/5e826dd14f0f7035aaec534351d1634f65f2be36.patch

---

diff --git a/Makefile.defs b/Makefile.defs
index 5400195..5495343 100644
--- a/Makefile.defs
+++ b/Makefile.defs
@@ -1863,22 +1863,6 @@ ifeq ($(OS), openbsd)
 	YACC=yacc
 	# unfortunately pthread is needed for sigwait
 	LIBS= -lpthread
-	OPENBSD_IS_AOUT:= $(shell echo "$(OSREL)" | \
-				sed -e 's/^3\.[0-3][^0-9]*$$/yes/' |sed -e 's/^[0-2]\..*/yes/')
-# exception: on sparc openbsd 3.2 is elf and not aout
-ifeq ($(OSREL), 3.2)
-ifeq	($(ARCH), sparc)
-		OPENBSD_IS_AOUT:=no
-endif
-ifeq	($(ARCH), sparc64)
-		OPENBSD_IS_AOUT:=no
-endif
-endif
-	
-ifeq ($(OPENBSD_IS_AOUT), yes)
-		C_DEFS+=-DDLSYM_PREFIX='"_"'
-		LDFLAGS=        # openbsd ld doesn't like -O2 or -E
-endif
 endif   # if opensd
 	
 ifeq ($(OS), netbsd)
diff --git a/sr_module.c b/sr_module.c
index 057bf02..6ddbd00 100644
--- a/sr_module.c
+++ b/sr_module.c
@@ -381,23 +381,18 @@ static int register_module(unsigned ver, union module_exports_u* e,
 	return ret;
 }
 
-#ifndef DLSYM_PREFIX
-/* define it to null */
-#define DLSYM_PREFIX
-#endif
-
 static inline int version_control(void *handle, char *path)
 {
 	char **m_ver;
 	char **m_flags;
 	char* error;
 
-	m_ver=(char **)dlsym(handle, DLSYM_PREFIX "module_version");
+	m_ver=(char **)dlsym(handle, "module_version");
 	if ((error=(char *)dlerror())!=0) {
 		LM_ERR("no version info in module <%s>: %s\n", path, error);
 		return 0;
 	}
-	m_flags=(char **)dlsym(handle, DLSYM_PREFIX "module_flags");
+	m_flags=(char **)dlsym(handle, "module_flags");
 	if ((error=(char *)dlerror())!=0) {
 		LM_ERR("no compile flags info in module <%s>: %s\n", path, error);
 		return 0;
@@ -587,14 +582,13 @@ int load_module(char* mod_path)
 	if (!version_control(handle, path)) {
 		exit(-1);
 	}
-	mod_if_ver = (unsigned *)dlsym(handle,
-									DLSYM_PREFIX "module_interface_ver");
+	mod_if_ver = (unsigned *)dlsym(handle, "module_interface_ver");
 	if ( (error =(char*)dlerror())!=0 ){
 		LM_ERR("no module interface version in module <%s>\n", path );
 		goto error1;
 	}
 	/* launch register */
-	mr = (mod_register_function)dlsym(handle, DLSYM_PREFIX "mod_register");
+	mr = (mod_register_function)dlsym(handle, "mod_register");
 	if (((error =(char*)dlerror())==0) && mr) {
 		/* no error call it */
 		new_dlflags=dlflags;
@@ -612,7 +606,7 @@ int load_module(char* mod_path)
 			goto error;
 		}
 	}
-	exp = (union module_exports_u*)dlsym(handle, DLSYM_PREFIX "exports");
+	exp = (union module_exports_u*)dlsym(handle, "exports");
 	if(exp==NULL) {
 		/* 'exports' structure not found, look up for '_modulename_exports' */
 		mdir = strrchr(mod_path, '/');
@@ -624,7 +618,7 @@ int load_module(char* mod_path)
 		expref.len = strlen(expref.s);
 		if(expref.len>3 && strcmp(expref.s+expref.len-3, ".so")==0)
 			expref.len -= 3;
-		snprintf(exbuf, 62, DLSYM_PREFIX "_%.*s_exports", expref.len, expref.s);
+		snprintf(exbuf, 62, "_%.*s_exports", expref.len, expref.s);
 		exp = (union module_exports_u*)dlsym(handle, exbuf);
 		LM_DBG("looking up exports with name: %s\n", exbuf);
 		if ( (error =(char*)dlerror())!=0 ){




More information about the sr-dev mailing list