[sr-dev] [kamailio] Deadlock in pua_reginfo (v4.2.6) (#499)

[bpetscho]

Hi,

after receiving a register the kamailio process ends up in a deadlock when calling the function:
```
res = ulget_urecord_by_ruid(domain, ulget_aorhash(c->aor), &(c->ruid),
		&record, &_c);
(usrloc_cbc:264)
```

System setup:
Kamailio version 426 together with postgres
pua_reginfo module enabled (modparam publish_reginfo needs to be set to "1")
To reproduce it is enough to send a single registration


According the change notes the function to get the record was changed from "ulget_urecord" to "ulget_urecord_by_ruid" in release 426
http://wwwkamailioorg/pub/kamailio/426/ChangeLog
> commit 547f1489cb51a3c72dba72adaa1f6df5429f425e
> Author: Victor Seva <linuxmaniac at torreviejawirelessorg>
> Date:   Wed Jul 15 16:00:03 2015 +0200
> 
>     pua_reginfo: use ruid to fix comparation of contact
>     
>     (ptr == c) is always false Using ruid instead
>     
>     (cherry picked from commit 7d31d78e3ac861cddfcb70c9940242ec7f3f0dbc)
> 
> commit eb97d380a2fca3b9ce30596aad9493bc11cd5d8d
> Author: Victor Seva <linuxmaniac at torreviejawirelessorg>
> Date:   Thu May 28 18:26:08 2015 +0200
> 
>     pua_reginfo: use ulget_urecord_by_ruid instead of ulget_urecord
>     
>     (cherry picked from commit 63bd356cc3c7aa64d64361283f630f88b8db88af)
> 


A similair change was done in 43x and reverted short time later:
http://wwwkamailioorg/pub/kamailio/434/ChangeLog
> commit cb644d50f76c80f0f24b34e5adf8723d89aab636
> Author: Victor Seva <linuxmaniac at torreviejawirelessorg>
> Date:   Thu Aug 6 15:22:34 2015 +0200
> 
>     Revert "pua_reginfo: use ulget_urecord_by_ruid instead of ulget_urecord"
>     
>     This reverts commit 9a6d8d2bffe13b442ed5e880fb0dd2c6572c29e2
> 

Just by the change notes I cannot find out, why the commit was reverted in 432
As a workaround, we changed the used function back to "ulget_urecord" and have now running tests to verify the functionality At least the deadlock is fixed with this change



---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/499
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20160205/11b5e531/attachment.html>