[sr-dev] [kamailio/kamailio] Sipcapture: When inserting a reply, this module would insert the SIP … (#876)

[David Villasmil]

The way it works now, on a reply the SIP Status is inserted into the "method" field, this isn't very nice as, if you're working with the table, you'd need to actually look into the cseq and break it into Sequence and Method to be able to do anything useful. Then you'd need to check if the "method" field is an actual method or a status code. The patch makes it much more readable:

```
+---------------------+------------------+--------+--------+-------------------------------+--------------------------------------+
| date                | micro_ts         | method | status | reply_reason                  | ruri                                 |
+---------------------+------------------+--------+--------+-------------------------------+--------------------------------------+
| 2016-12-01 02:18:31 | 1480558711188146 | INVITE |        |                               | sip:12345 at 1.2.3.4                    |
| 2016-12-01 02:18:31 | 1480558711188584 | INVITE | 100    | Trying                        |                                      |
| 2016-12-01 02:18:31 | 1480558711189884 | INVITE | 407    | Proxy Authentication Required |                                      |
| 2016-12-01 02:18:31 | 1480558711391719 | ACK    |        |                               | sip:12345 at 1.2.3.4                    |
| 2016-12-01 02:18:31 | 1480558711391871 | INVITE |        |                               | sip:12345 at 1.2.3.4                    |
| 2016-12-01 02:18:31 | 1480558711392194 | INVITE | 100    | Trying                        |                                      |
| 2016-12-01 02:18:31 | 1480558711411499 | INVITE | 403    | Forbidden                     |                                      |
| 2016-12-01 02:18:31 | 1480558711796623 | ACK    |        |                               | sip:12345 at 1.2.3.4                    |

```
Which is easier to read than the current way:

```
+---------------------+------------------+--------+-------------------------------+--------------------------------------+
| date                | micro_ts         | method | reply_reason                  | ruri                                 |
+---------------------+------------------+--------+-------------------------------+--------------------------------------+
| 2016-12-01 02:18:31 | 1480558711188146 | INVITE |                               | sip:12345 at 1.2.3.4                    |
| 2016-12-01 02:18:31 | 1480558711188584 | 100    | Trying                        |                                      |
| 2016-12-01 02:18:31 | 1480558711189884 | 407    | Proxy Authentication Required |                                      |
| 2016-12-01 02:18:31 | 1480558711391719 | ACK    |                               | sip:12345 at 1.2.3.4                    |
| 2016-12-01 02:18:31 | 1480558711391871 | INVITE |                               | sip:12345 at 1.2.3.4                    |
| 2016-12-01 02:18:31 | 1480558711392194 | 100    | Trying                        |                                      |
| 2016-12-01 02:18:31 | 1480558711411499 | 403    | Forbidden                     |                                      |
| 2016-12-01 02:18:31 | 1480558711796623 | ACK    |                               | sip:12345 at 1.2.3.4                    |

```

Also, I'm doing a PR to homer as well to take into account this change, which will show in the "sip search" as a "Status" column.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/876#issuecomment-264192515
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20161201/4f49248c/attachment.html>