[sr-dev] [kamailio] tm: fake msg and environment to append new branches (#346)

Federico Cabiddu notifications at github.com
Mon Sep 28 09:19:00 CEST 2015


This fix try to solve the crash reported in http://lists.sip-router.org/pipermail/sr-users/2015-September/089846.html. The cause of the crash was that the sip message used to append branch was the shmem clone of the original message. When the new branches were going through their configured  branch route, modifications done by other modules' function (like rtpproxy) were applied to this stored copy directly, causing the crash once a failure route was run.
This patch take the same approach as the failure handler one, creating a fake request from the origin message and using this one to append branches. I am not sure if this is a good approach, since the appended branch are going through the branch route and some function called there could not be compatible with a faked request.
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/346

-- Commit Summary --

  * tm: fake msg and environment to append new branches

-- File Changes --

    M modules/tm/t_append_branches.c (54)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/346.patch
https://github.com/kamailio/kamailio/pull/346.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/346
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20150928/98d6a0f3/attachment.html>


More information about the sr-dev mailing list