[sr-dev] git:master:b846c216: Merge pull request #335 from doublec/tsilo_pointer_comparison

[Federico Cabiddu]

Module: kamailio
Branch: master
Commit: b846c216f5244049463c49ccefaaadb1c2bcfb10
URL: https://github.com/kamailio/kamailio/commit/b846c216f5244049463c49ccefaaadb1c2bcfb10

Author: Federico Cabiddu <federico.cabiddu at gmail.com>
Committer: Federico Cabiddu <federico.cabiddu at gmail.com>
Date: 2015-09-23T14:08:10+02:00

Merge pull request #335 from doublec/tsilo_pointer_comparison

tsilo: Fix pointer comparison in ts_set_tm_callbacks

---

Modified: modules/tsilo/ts_handlers.c

---

Diff:  https://github.com/kamailio/kamailio/commit/b846c216f5244049463c49ccefaaadb1c2bcfb10.diff
Patch: https://github.com/kamailio/kamailio/commit/b846c216f5244049463c49ccefaaadb1c2bcfb10.patch

---

diff --git a/modules/tsilo/ts_handlers.c b/modules/tsilo/ts_handlers.c
index 7cf7970..0df6358 100644
--- a/modules/tsilo/ts_handlers.c
+++ b/modules/tsilo/ts_handlers.c
@@ -40,14 +40,11 @@ int ts_set_tm_callbacks(struct cell *t, sip_msg_t *req, ts_transaction_t *ts)
 	if(t==NULL)
 		return -1;
 
-	if ( (ts_clone=clone_ts_transaction(ts)) < 0 ) {
+	if ( (ts_clone=clone_ts_transaction(ts)) == NULL ) {
 		LM_ERR("failed to clone transaction\n");
 		return -1;
 	}
 
-	if (ts_clone == NULL) {
-		LM_ERR("transaction clone null\n");
-	}
 	if ( _tmb.register_tmcb( req, t,TMCB_DESTROY,
 			ts_onreply, (void*)ts_clone, free_ts_transaction)<0 ) {
 		LM_ERR("failed to register TMCB for transaction %d:%d\n", t->hash_index, t->label);