[sr-dev] [kamailio] Return CSCF_RETURN_FALSE if AAR is not generated (#314)

Federico Favaro notifications at github.com
Thu Sep 3 12:10:28 CEST 2015


Differentiate the cases where AAR is not sent because
of an error and the cases where AAR is not sent because it is logically wrong to sent them at that point of the transaction. In this way, in the routing script it is possible to distinguish between an error and (for example) send back an error to the UE and when AAR is not generated because (for example) the answer does not contain an SDP or you are not in a SIP reply. In this case, you should not send back an error but go ahead with your transaction.
I noticed that CSCF_RETURN_FALSE (-1) is never used in the function, so it can be suitable to be returned in the cases just explained
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/314

-- Commit Summary --

  * Return CSCF_RETURN_FALSE if AAR is not generated

-- File Changes --

    M modules/ims_qos/mod.c (21)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/314.patch
https://github.com/kamailio/kamailio/pull/314.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/314
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20150903/10b0ef00/attachment.html>


More information about the sr-dev mailing list