[sr-dev] git:master:b71143a6: modules/ims_registrar_pcscf: remove erroneous return

[jaybeepee]

Module: kamailio
Branch: master
Commit: b71143a6b16975e695a814fe5c7e865f579e9dd3
URL: https://github.com/kamailio/kamailio/commit/b71143a6b16975e695a814fe5c7e865f579e9dd3

Author: jaybeepee <jason.penton at gmail.com>
Committer: jaybeepee <jason.penton at gmail.com>
Date: 2015-10-28T10:41:58+02:00

modules/ims_registrar_pcscf: remove erroneous return

---

Modified: modules/ims_registrar_pcscf/service_routes.c

---

Diff:  https://github.com/kamailio/kamailio/commit/b71143a6b16975e695a814fe5c7e865f579e9dd3.diff
Patch: https://github.com/kamailio/kamailio/commit/b71143a6b16975e695a814fe5c7e865f579e9dd3.patch

---

diff --git a/modules/ims_registrar_pcscf/service_routes.c b/modules/ims_registrar_pcscf/service_routes.c
index 05a7987..00d6076 100644
--- a/modules/ims_registrar_pcscf/service_routes.c
+++ b/modules/ims_registrar_pcscf/service_routes.c
@@ -308,7 +308,11 @@ int check_service_routes(struct sip_msg* _m, udomain_t* _d) {
 	/* Lock this record while working with the data: */
 	ul.lock_udomain(_d, &vb->host, port, proto);
         
-        pcontact_t * c = getContactP(_m, _d);
+	pcontact_t * c = getContactP(_m, _d);
+	if (!c) {
+		LM_DBG("no contact found in usrloc when checking for service route\n");
+		goto error;
+	}
 
 	/* Check the route-set: */
 	if (_m->route) {
@@ -386,7 +390,6 @@ int check_service_routes(struct sip_msg* _m, udomain_t* _d) {
 	/* Unlock domain */
 	ul.unlock_udomain(_d, &vb->host, port, proto);
 	return -1;
-    return 1;
 }
 
 static str route_start={"Route: <",8};