[sr-dev] git:master:09c5e606: tcpops Add tcp_conid_state function to check connection state

Daniel-Constantin Mierla miconda at gmail.com
Fri Oct 2 08:42:22 CEST 2015



On 02/10/15 07:16, Olle E. Johansson wrote:
>> On 01 Oct 2015, at 23:07, Daniel-Constantin Mierla <miconda at gmail.com> wrote:
>>
>> I pushed two commits, because yours was resulting in compile errors due
>> to different name in declaration of the function prototype. Then I
>> noticed that the connection was not released after it was looked up. I
>> hope I haven't broken other stuff.
> Thanks. Changed the name in last minute based on suggestions, but wasn’t
> awake enough to really test again… Ouch.
>> On the other hand, an explicit function to use when needing to test if
>> connection is ok could me more user friendly than handling all the
>> return codes.
>> So adding one may worth the trouble for few more lines of
>> code.
> You mean adding my original idea of a function with just true/false checks?
> I can do that.
>
>
Yes, a function to just say true if the connection is alive, that's what
I expect to be the common use case. Accepting and connecting states are
not for the connections that already received a register packet, but the
existion function is returning true, if some one wants to use a simple
if(...).

Cheers,
Daniel

-- 
Daniel-Constantin Mierla
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
Book: SIP Routing With Kamailio - http://www.asipto.com
Kamailio Advanced Training - http://asipto.com/u/kat




More information about the sr-dev mailing list