[sr-dev] git:master:64491668: modules/ims_qos: correct analysis of return value for t_suspend

jaybeepee jason.penton at gmail.com
Mon Nov 30 20:07:46 CET 2015


Module: kamailio
Branch: master
Commit: 64491668d61b14c213e3fc0a0b55cfcf6c036e39
URL: https://github.com/kamailio/kamailio/commit/64491668d61b14c213e3fc0a0b55cfcf6c036e39

Author: jaybeepee <jason.penton at gmail.com>
Committer: jaybeepee <jason.penton at gmail.com>
Date: 2015-11-30T21:07:37+02:00

modules/ims_qos: correct analysis of return value for t_suspend

---

Modified: modules/ims_qos/mod.c
Modified: modules/ims_registrar_scscf/save.c

---

Diff:  https://github.com/kamailio/kamailio/commit/64491668d61b14c213e3fc0a0b55cfcf6c036e39.diff
Patch: https://github.com/kamailio/kamailio/commit/64491668d61b14c213e3fc0a0b55cfcf6c036e39.patch

---

diff --git a/modules/ims_qos/mod.c b/modules/ims_qos/mod.c
index cb64390..6a84131 100644
--- a/modules/ims_qos/mod.c
+++ b/modules/ims_qos/mod.c
@@ -1055,7 +1055,7 @@ static int w_rx_aar_register(struct sip_msg *msg, char* route, char* str1, char*
     }
 
     LM_DBG("Suspending SIP TM transaction\n");
-    if (tmb.t_suspend(msg, &saved_t_data->tindex, &saved_t_data->tlabel) < 0) {
+    if (tmb.t_suspend(msg, &saved_t_data->tindex, &saved_t_data->tlabel) != 0) {
         LM_ERR("failed to suspend the TM processing\n");
         free_saved_transaction_global_data(saved_t_data);
         return CSCF_RETURN_ERROR;
diff --git a/modules/ims_registrar_scscf/save.c b/modules/ims_registrar_scscf/save.c
index ff75a0d..da1dc69 100644
--- a/modules/ims_registrar_scscf/save.c
+++ b/modules/ims_registrar_scscf/save.c
@@ -1128,7 +1128,7 @@ int assign_server_unreg(struct sip_msg* _m, char* str1, str* direction, char* ro
     create_return_code(CSCF_RETURN_ERROR);
 
     LM_DBG("Suspending SIP TM transaction\n");
-    if (tmb.t_suspend(_m, &saved_t->tindex, &saved_t->tlabel) < 0) {
+    if (tmb.t_suspend(_m, &saved_t->tindex, &saved_t->tlabel) != 0) {
         LM_ERR("failed to suspend the TM processing\n");
         free_saved_transaction_data(saved_t);
         rerrno = R_SAR_FAILED;
@@ -1357,7 +1357,7 @@ int save(struct sip_msg* msg, char* str1, char *route) {
     create_return_code(CSCF_RETURN_ERROR);
 
     LM_DBG("Suspending SIP TM transaction\n");
-    if (tmb.t_suspend(msg, &saved_t->tindex, &saved_t->tlabel) < 0) {
+    if (tmb.t_suspend(msg, &saved_t->tindex, &saved_t->tlabel) != 0) {
         LM_ERR("failed to suspend the TM processing\n");
         free_saved_transaction_data(saved_t);
         rerrno = R_SAR_FAILED;




More information about the sr-dev mailing list