[sr-dev] git:master:5e6cec1d: modules/ims_charging: fixes always true comparison of unsigned int

Mikko Lehto mslehto at iki.fi
Thu Nov 12 12:11:06 CET 2015


Module: kamailio
Branch: master
Commit: 5e6cec1d01e676d78c4a21e48de3e0908e39de8f
URL: https://github.com/kamailio/kamailio/commit/5e6cec1d01e676d78c4a21e48de3e0908e39de8f

Author: Mikko Lehto <mslehto at iki.fi>
Committer: Mikko Lehto <mslehto at iki.fi>
Date: 2015-11-11T22:46:30+02:00

modules/ims_charging: fixes always true comparison of unsigned int

---

Modified: modules/ims_charging/ro_timer.c

---

Diff:  https://github.com/kamailio/kamailio/commit/5e6cec1d01e676d78c4a21e48de3e0908e39de8f.diff
Patch: https://github.com/kamailio/kamailio/commit/5e6cec1d01e676d78c4a21e48de3e0908e39de8f.patch

---

diff --git a/modules/ims_charging/ro_timer.c b/modules/ims_charging/ro_timer.c
index df1fc59..f5978d6 100644
--- a/modules/ims_charging/ro_timer.c
+++ b/modules/ims_charging/ro_timer.c
@@ -409,7 +409,7 @@ void ro_session_ontimeout(struct ro_tl *tl) {
             counter_add(ims_charging_cnts_h.billed_secs, used_secs);
 
             if (ro_session->callid.s != NULL
-                    && ro_session->dlg_h_entry >= 0
+                    && ro_session->dlg_h_entry > 0
                     && ro_session->dlg_h_id > 0
                     && ro_session->ro_session_id.s != NULL) {
                 LM_DBG("Found a session to re-apply for timing [%.*s] and user is [%.*s]\n",




More information about the sr-dev mailing list