[sr-dev] git:master:1da0f06d: modules/tm: removed no longer needed ASYNC mutex

[Daniel-Constantin Mierla]

Hello,

I see you removed also the flag T_ASYNC_CONTINUE that marked the
transaction being in a t_continue operation -- some of the changed
chunks (there are few more related):

-        if ( t->uac[b].last_received<200 &&
!((t->flags&T_ASYNC_CONTINUE) && b==t->async_backup.blind_uac))
+        if (t->uac[b].last_received<200)

Was that needed and is the new code (all those conditions) now safe?

Overall the flag was not related to async_mutex and can be kept even
when using the reply_lock. In my code with defines the flag was left in
place, protected by reply_lock.

Cheers,
Daniel

On 13/05/15 09:15, jaybeepee wrote:
> Module: kamailio
> Branch: master
> Commit: 1da0f06d896ed8a99728846437322a3719241fbc
> URL: https://github.com/kamailio/kamailio/commit/1da0f06d896ed8a99728846437322a3719241fbc
>
> Author: jaybeepee <jason.penton at gmail.com>
> Committer: jaybeepee <jason.penton at gmail.com>
> Date: 2015-05-13T09:14:44+02:00
>
> modules/tm: removed no longer needed ASYNC mutex
>
> ---
>
> Modified: modules/tm/h_table.h
> Modified: modules/tm/lock.c
> Modified: modules/tm/t_reply.c
> Modified: modules/tm/t_suspend.c
>
> ---
>
> Diff:  https://github.com/kamailio/kamailio/commit/1da0f06d896ed8a99728846437322a3719241fbc.diff
> Patch: https://github.com/kamailio/kamailio/commit/1da0f06d896ed8a99728846437322a3719241fbc.patch
>
>
> _______________________________________________
> sr-dev mailing list
> sr-dev at lists.sip-router.org
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

-- 
Daniel-Constantin Mierla
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
Kamailio World Conference, May 27-29, 2015
Berlin, Germany - http://www.kamailioworld.com