[sr-dev] request for backporting to 4.2 - presence_dialoginfo : optionally send dummy dialog

[Daniel-Constantin Mierla]

Hello,

ok, you can backport the patch to 4.2.

Cheers,
Daniel

On Thu, Jan 29, 2015 at 12:15 PM, Luis Azedo <luis at 2600hz.com> wrote:

>  Hi Daniel,
>
>  the current behaviour is, if the body is NULL it doesn't send the body,
> which works with most phones.
>
>   NOTIFY sip:user_7z7b6s at 192.168.16.12:49454;transport=udp SIP/2.0
>  Via: SIP/2.0/UDP 192.168.16.155;branch=z9hG4bK7b96.
> 7cb452f2000000000000000000000000.0
>  To: <sip:user_7z7b6s at test.sip.com <sip%3Auser_7z7b6s at teste.sip.90e9.com>
> >;tag=25ad9c33
>  From: <sip:995582134 at test.sip.com <sip%3A995582134 at teste.sip.90e9.com>
> >;tag=bc2b9f04dce18e817c04a8a86ca55108-f69b
>  CSeq: 2 NOTIFY
>  Call-ID: NWEyNmRmMjg2YmJhMjQ0MWM2Y2Y1OTNjNTFhZDU1ZmY
>  Content-Length: 0
>  Max-Forwards: 70
>  Event: dialog
>  Contact: <sip:192.168.16.155:5060;transport=udp>
>  Subscription-State: active;expires=1800
>
>  *with the patch, if param force_dummy_dialog = 1*
>
>   NOTIFY sip:user_7z7b6s at 192.168.16.12:49454;transport=udp SIP/2.0
>  Via: SIP/2.0/UDP 192.168.16.155;branch=z9hG4bK811e.
> 7c3b7b25000000000000000000000000.0
>  To: <sip:user_7z7b6s at test.sip.com <sip%3Auser_7z7b6s at teste.sip.90e9.com>
> >;tag=4dce5b3e
>  From: <sip:995582135 at test.sip.com <sip%3A995582135 at teste.sip.90e9.com>
> >;tag=bc2b9f04dce18e817c04a8a86ca55108-bab8
>  CSeq: 2 NOTIFY
>  Call-ID: MTY0Zjk1ZWFhOGI2OTBmNTM1MTQ4NmMxN2Q1OTlmNGQ
>  Content-Length: 246
>  Max-Forwards: 70
>  Event: dialog
>  Contact: <sip:192.168.16.155:5060;transport=udp>
>  Subscription-State: active;expires=1800
>  Content-Type: application/dialog-info+xml
>
>  <?xml version="1.0"?>
>  <dialog-info xmlns="urn:ietf:params:xml:ns:dialog-info" version="1"
>       state="full" entity="sip:995582134 at test.sip.com
> <sip%3A995582135 at teste.sip.90e9.com>">
>    <dialog direction="recipient">
>      <state>terminated</state>
>    </dialog>
>  </dialog-info>
>
>  which works for astra and bria (maybe others) and also works for
> previously working phones (tested with polycom, cisco, jitsi)
>
>
>  ------------------------------
> *From:* sr-dev [sr-dev-bounces at lists.sip-router.org] on behalf of
> Daniel-Constantin Mierla [miconda at gmail.com]
> *Sent:* Thursday, January 29, 2015 1:53 AM
> *To:* Kamailio (SER) - Development Mailing List
> *Subject:* Re: [sr-dev] request for backporting to 4.2 -
> presence_dialoginfo : optionally send dummy dialog
>
>  Hello,
>
> On 28/01/15 23:19, Luis Azedo wrote:
>
>
>    Hi List,
>
>  some sip clients like Bria and some sip phones like Astra
> expect a <dialog-info><dialog></dialog></dialog-info>
> on the NOTIFY message sent.
>
>  presence sends a NOTIFY after the SUBSCRIBE with NULL body if it doesn't
> find the presentity.
>
>
> for clarification, the body is empty, not with a string NULL, isn't it?
>
> Even it adds a new module parameter, the behaviour is preserved, and given
> bria and astra are quite spread, I am ok to backport. Let's see if others
> are fine as well.
>
> Cheers,
> Daniel
>
>
>  the patch already in master allows to configure the creation of a dummy
> dialog to be sent when presence doesn't find the presentity.
>
>  this behavior was only observed in dialog subscriptions so the patch was
> made against presence_dialoginfo.
>
>  *the new param force_dummy_dialog defaults to 0 to preserve existing
> behavior.*
>
>  using this patch Bria, Astra started working with BLF and others (Cisco,
> Polycom, Jitsi) kept running.
>
>  does anyone have anything against backporting this to 4.2 ?
>
>  Best
>
>
>
> _______________________________________________
> sr-dev mailing listsr-dev at lists.sip-router.orghttp://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
>
>
> --
> Daniel-Constantin Mierlahttp://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
>
>


-- 
Daniel-Constantin Mierla - http://www.asipto.com
http://twitter.com/#!/miconda - http://www.linkedin.com/in/micond
<http://www.linkedin.com/in/miconda>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20150130/1b3b792e/attachment-0001.html>