[sr-dev] git:master:6daf77d6: mohqueue Remove SVN IDs, add some \n at end of error messages

[Olle E. Johansson]

On 17 Jan 2015, at 14:43, Robert Boisvert <rdboisvert at gmail.com> wrote:

> Olle,
> 
> Please address your concerns to me so I can look into them.
Hi!
Thanks for a quick response!
- LM_DBG and LM_ERR needs to be terminated with \n
I did fix a few - but there's a lot more fixing to be done.

See how mohqueue stacks error messages on top of each other here where they should be on one line each.

 0(92166) DEBUG: <core> [sr_module.c:731]: find_mod_export(): <db_query_lock> in module <db_mysql> not found
 0(92166) ERROR: <core> [db.c:73]: db_check_api(): module db_mysql does not export db_use_table function. Please check if module is loaded.
 0(92166) ERROR: mohqueue [mohq.c:236]: init_db(): Unable to bind DB API using mysql://kamailio:kamailiorw@localhost/kamailio 0(92166) ERROR: <core> [sr_module.c:945]: init_mod(): Error while initializing module mohqueue (/usr/local/lib64/kamailio/modules/mohqueue.so)
ERROR: error while initializing modules
 0(92166) DEBUG: xprint [xprint.c:174]: destroy(): destroy module ...


It may be my personal opinion, but comparing the source code formatting in the mohqueue
source code files with other modules, it is not very well formatted. 

Regards,
/O

> 
> Thanks,
> Bob
> 
> On Sat, Jan 17, 2015 at 6:34 AM, Olle E. Johansson <oej at edvina.net> wrote:
> Module: kamailio
> Branch: master
> Commit: 6daf77d666ff0fcb1bd8df4bb3c63dc0fdac9656
> URL: https://github.com/kamailio/kamailio/commit/6daf77d666ff0fcb1bd8df4bb3c63dc0fdac9656
> 
> Author: Olle E. Johansson <oej at edvina.net>
> Committer: Olle E. Johansson <oej at edvina.net>
> Date: 2015-01-17T12:33:45+01:00
> 
> mohqueue Remove SVN IDs, add some \n at end of error messages
> 
> More cleanup of LM_DBG and LM_ERR needed, as well as code formatting
> 
> ---
> 
> Modified: modules/mohqueue/mohq.c
> Modified: modules/mohqueue/mohq.h
> Modified: modules/mohqueue/mohq_common.h
> Modified: modules/mohqueue/mohq_db.c
> Modified: modules/mohqueue/mohq_db.h
> Modified: modules/mohqueue/mohq_funcs.c
> Modified: modules/mohqueue/mohq_funcs.h
> Modified: modules/mohqueue/mohq_locks.c
> Modified: modules/mohqueue/mohq_locks.h
> 
> ---
> 
> Diff:  https://github.com/kamailio/kamailio/commit/6daf77d666ff0fcb1bd8df4bb3c63dc0fdac9656.diff
> Patch: https://github.com/kamailio/kamailio/commit/6daf77d666ff0fcb1bd8df4bb3c63dc0fdac9656.patch
> 
> 
> _______________________________________________
> sr-dev mailing list
> sr-dev at lists.sip-router.org
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
> 
> _______________________________________________
> sr-dev mailing list
> sr-dev at lists.sip-router.org
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20150117/4bcd7bb6/attachment.html>