[sr-dev] [kamailio] siputils: fix for e164_check() (#28)

Daniel-Constantin Mierla notifications at github.com
Thu Jan 15 17:11:36 CET 2015


The issue solved by a previous patch was that is_e164() was returning always true -- it was checking that (c<'0' && c>'9') to say it is not e164, which never happens.

The issue solved by the patch on this item was about going over the length of the parameter with 1, which was even before the first patch.

After the first patch, the effect of second issue going over the length, results in checking an extra character which very likely is not a digit.

In other words, the first fix revealed another bug by enabling a side effect of it in most of the cases.

---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/28#issuecomment-70110158
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20150115/4bde19c6/attachment-0001.html>


More information about the sr-dev mailing list