[sr-dev] git:master:338b00c0: sl: don't remove the lump added in the 'after' list of delete lump

Daniel-Constantin Mierla miconda at gmail.com
Thu Jan 15 14:30:48 CET 2015


Module: kamailio
Branch: master
Commit: 338b00c0f2d38694cffe3536e7eeed0e0d5372dd
URL: https://github.com/kamailio/kamailio/commit/338b00c0f2d38694cffe3536e7eeed0e0d5372dd

Author: Daniel-Constantin Mierla <miconda at gmail.com>
Committer: Daniel-Constantin Mierla <miconda at gmail.com>
Date: 2015-01-15T13:42:13+01:00

sl: don't remove the lump added in the 'after' list of delete lump

- they are destroyed together, making the operation useless

---

Modified: modules/sl/sl.c

---

Diff:  https://github.com/kamailio/kamailio/commit/338b00c0f2d38694cffe3536e7eeed0e0d5372dd.diff
Patch: https://github.com/kamailio/kamailio/commit/338b00c0f2d38694cffe3536e7eeed0e0d5372dd.patch

---

diff --git a/modules/sl/sl.c b/modules/sl/sl.c
index 3a8cea2..5f3febb 100644
--- a/modules/sl/sl.c
+++ b/modules/sl/sl.c
@@ -437,9 +437,8 @@ static int w_sl_forward_reply(sip_msg_t* msg, str* code, str* reason)
 	if(reason!=NULL) {
 		if(ldel!=NULL) {
 			remove_lump(msg, ldel);
-		}
-		if(ladd!=NULL) {
-			remove_lump(msg, ladd);
+			/* ladd is liked in the 'after' list inside ldel,
+			 * destroyed together, no need for its own remove operation */
 		}
 	}
 	if(code!=NULL) {




More information about the sr-dev mailing list