[sr-dev] git:master:0e1b2bc9: modules/ims_registrar_scscf: added logging of return code on NOTIFY response

[Richard Good]

Apologies - just extending lines from legacy code from the OpenIMSCore
project.  I'll correct these and commit as I note them.

Regards


*Richard Good*
*Senior Manager: Applications & Services*  *Smile Communications Pty (Ltd)*
*Mobile:*  +27 (0) 72 389 8365   * Skype:*  richard.a.good
   richard.good at smilecoms.com <name.surname at smilecoms.com>
www.smilecoms.com




On 13 January 2015 at 16:11, Ovidiu Sas <osas at voipembedded.com> wrote:

> The debug probe text should not explicitly specify the log level and
> the calling function.
> All that info is automatically handled/added by the LM_ macro.
>
> LM_DBG("received NOTIFY reply type [%d] and code [%d]\n", type, ps->code);
>
> -ovidiu
>
> On Tue, Jan 13, 2015 at 8:59 AM, Richard Good
> <richard.good at smilecoms.com> wrote:
> > Module: kamailio
> > Branch: master
> > Commit: 0e1b2bc99e04547b8a7482197412dc9b866eb320
> > URL:
> https://github.com/kamailio/kamailio/commit/0e1b2bc99e04547b8a7482197412dc9b866eb320
> >
> > Author: Richard Good <richard.good at smilecoms.com>
> > Committer: Richard Good <richard.good at smilecoms.com>
> > Date: 2015-01-13T15:58:38+02:00
> >
> > modules/ims_registrar_scscf: added logging of return code on NOTIFY
> response
> >
> > ---
> >
> > Modified: modules/ims_registrar_scscf/registrar_notify.c
> >
> > ---
> >
> > Diff:
> https://github.com/kamailio/kamailio/commit/0e1b2bc99e04547b8a7482197412dc9b866eb320.diff
> > Patch:
> https://github.com/kamailio/kamailio/commit/0e1b2bc99e04547b8a7482197412dc9b866eb320.patch
> >
> > ---
> >
> > diff --git a/modules/ims_registrar_scscf/registrar_notify.c
> b/modules/ims_registrar_scscf/registrar_notify.c
> > index 5f131d9..1831b9f 100644
> > --- a/modules/ims_registrar_scscf/registrar_notify.c
> > +++ b/modules/ims_registrar_scscf/registrar_notify.c
> > @@ -1764,7 +1764,7 @@ str get_reginfo_partial(impurecord_t *r,
> ucontact_t *c, int event_type) {
> >   * Callback for the UAC response to NOTIFY
> >   */
> >  void uac_request_cb(struct cell *t, int type, struct tmcb_params * ps) {
> > -    LM_DBG("DBG:uac_request_cb: Type %d\n", type);
> > +    LM_DBG("DBG: uac_request_cb on response to NOTIFY: Type %d and code
> %d\n", type, ps->code);
> >  }
> >
> >  static int free_tm_dlg(dlg_t * td) {
> >
> >
> > _______________________________________________
> > sr-dev mailing list
> > sr-dev at lists.sip-router.org
> > http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
>
>
>
> --
> VoIP Embedded, Inc.
> http://www.voipembedded.com
>
> _______________________________________________
> sr-dev mailing list
> sr-dev at lists.sip-router.org
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
>

-- 


This email is subject to the disclaimer of Smile Communications at http://www.smilecoms.com/home/email-disclaimer/ <http://www.smilecoms.com/disclaimer>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20150113/934c055b/attachment-0001.html>