[sr-dev] [kamailio] siputils: fix for e164_check() (#28)

[Daniel-Constantin Mierla]

Note for the future -- be sure the comments on the commits are providing proper details.

While the description here was correct, respectively:

"fix improper length check"

The commit has something else:

"- the condition for non-digit matching was always false"

Which can be a side effect in some cases, but not the real bug that was fixed. The commit didn't change anything that tested if a char is between 0 and 9.

In the future, be sure the commit message is giving the proper details, otherwise it can mislead. Commit logs are very important, more than the comments on issue tracker.



---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/28#issuecomment-69650662
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20150112/e75f745d/attachment.html>