[sr-dev] git:master:634db00a: uac: skip only the invalid record when loading remote registration records

Daniel-Constantin Mierla miconda at gmail.com
Thu Feb 26 22:00:32 CET 2015


Module: kamailio
Branch: master
Commit: 634db00a82f36c6c60d272ccada4a1d5338d1cbc
URL: https://github.com/kamailio/kamailio/commit/634db00a82f36c6c60d272ccada4a1d5338d1cbc

Author: Daniel-Constantin Mierla <miconda at gmail.com>
Committer: Daniel-Constantin Mierla <miconda at gmail.com>
Date: 2015-02-26T21:58:47+01:00

uac: skip only the invalid record when loading remote registration records

- fixes loading only the good records before the wrong record, thus
  working with partial valid data afterwards, even more valid records
  were in the db

---

Modified: modules/uac/uac_reg.c

---

Diff:  https://github.com/kamailio/kamailio/commit/634db00a82f36c6c60d272ccada4a1d5338d1cbc.diff
Patch: https://github.com/kamailio/kamailio/commit/634db00a82f36c6c60d272ccada4a1d5338d1cbc.patch

---

diff --git a/modules/uac/uac_reg.c b/modules/uac/uac_reg.c
index f0829fe..b52a044 100644
--- a/modules/uac/uac_reg.c
+++ b/modules/uac/uac_reg.c
@@ -1007,9 +1007,9 @@ void uac_reg_timer(unsigned int ticks)
 				(char*)(RES_ROWS(db_res)[i].values[pos].val.string_val); \
 			reg.attr.len = strlen(reg.attr.s); \
 			if(reg.attr.len == 0) { \
-				LM_ERR("empty value not allowed for column[%d]=%.*s\n", \
+				LM_ERR("empty value not allowed for column[%d]='%.*s' - ignoring record\n", \
 						pos, db_cols[pos]->len, db_cols[pos]->s); \
-				goto error; \
+				continue; \
 			} \
 		} \
 	} while(0);




More information about the sr-dev mailing list