[sr-dev] Buffer overflow in parse_hname2

Chris Double chris.double at double.co.nz
Mon Aug 31 05:06:46 CEST 2015


On Mon, Aug 31, 2015 at 12:34 PM, Chris Double
<chris.double at double.co.nz> wrote:
> Assuming my analysis is correct I'd like to fix this by putting some
> length checking in places and using a READ call that accounts for it.
> Would this be an acceptable approach? It's pretty complex code and I
> don't want to mess up so I welcome advice on how to address the issue
> if there's a better way.

I've done a minimal fix for the _reas_ case that we were hitting in
this pull request:

https://github.com/kamailio/kamailio/pull/308

What are the thoughts on doing similar for the other cases?

-- 
http://bluishcoder.co.nz



More information about the sr-dev mailing list