[sr-dev] [kamailio] Optionally init ndb_redis when redis is not available (#121)

Vicente Hernando vhernando at systemonenoc.com
Mon Apr 13 16:49:33 CEST 2015


Hello,

I do not like the idea behind the patch. If redis database is down, what 
is the point of launching kamailio anyway?
If you need redis to run you should fix it, or not to use the ndb_redis 
module if you want to run without redis.

Any other opinions are welcome.

Cheers,
Vicente.



On 04/13/2015 04:24 PM, Giacomo Vacca wrote:
> ------------------------------------------------------------------------
>
>
>         You can view, comment on, or merge this pull request online at:
>
> https://github.com/kamailio/kamailio/pull/121
>
>
>         Commit Summary
>
>   * ndb_redis: optionally allow mod init with redis unavailable
>   * ndb_redis: update doc with init_without_redis
>   * ndb_redis: update README with init_without_redis
>
>
>         File Changes
>
>   * *M* modules/ndb_redis/README
>     <https://github.com/kamailio/kamailio/pull/121/files#diff-0> (28)
>   * *M* modules/ndb_redis/doc/ndb_redis_admin.xml
>     <https://github.com/kamailio/kamailio/pull/121/files#diff-1> (19)
>   * *M* modules/ndb_redis/ndb_redis_mod.c
>     <https://github.com/kamailio/kamailio/pull/121/files#diff-2> (13)
>
>
>         Patch Links:
>
>   * https://github.com/kamailio/kamailio/pull/121.patch
>   * https://github.com/kamailio/kamailio/pull/121.diff
>
>> Reply to this email directly or view it on GitHub 
> <https://github.com/kamailio/kamailio/pull/121>.
>
>
>
> _______________________________________________
> sr-dev mailing list
> sr-dev at lists.sip-router.org
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20150413/e30ebf79/attachment.html>


More information about the sr-dev mailing list