[sr-dev] git:master:224e34a5: modules/ims_charging: return if no reply associated with dlg

[jaybeepee]

Module: kamailio
Branch: master
Commit: 224e34a55b012ee46996bb4d86e662d99e4c0541
URL: https://github.com/kamailio/kamailio/commit/224e34a55b012ee46996bb4d86e662d99e4c0541

Author: jaybeepee <jason.penton at gmail.com>
Committer: jaybeepee <jason.penton at gmail.com>
Date: 2015-04-08T15:27:14+02:00

modules/ims_charging: return if no reply associated with dlg
       - prevents possible segfault
       - also removed old commented code

---

Modified: modules/ims_charging/dialog.c

---

Diff:  https://github.com/kamailio/kamailio/commit/224e34a55b012ee46996bb4d86e662d99e4c0541.diff
Patch: https://github.com/kamailio/kamailio/commit/224e34a55b012ee46996bb4d86e662d99e4c0541.patch

---

diff --git a/modules/ims_charging/dialog.c b/modules/ims_charging/dialog.c
index f564fcb..0548fee 100644
--- a/modules/ims_charging/dialog.c
+++ b/modules/ims_charging/dialog.c
@@ -27,26 +27,8 @@ void dlg_reply(struct dlg_cell *dlg, int type, struct dlg_cb_params *_params) {
 	reply = _params->rpl;
 	if (!reply) {
 		LM_WARN("dlg_reply has no SIP reply associated.\n");
+		return;
 	}
-	
-//	if (reply != FAKED_REPLY && reply->REPLY_STATUS == 200) {
-//		//get CC session from callback param
-//		char* cdp_session_id = (char*)*_params->param;
-//		LM_INFO("Call answered\n");
-//		LM_DBG("Call answered and we have a session id of [%s]\n", cdp_session_id);
-//
-//		str session_id;
-//		session_id.s = cdp_session_id;
-//		session_id.len = strlen(cdp_session_id);
-//		AAASession* cdp_session = cdpb.AAAGetCCAccSession(session_id);
-//		if (!cdp_session) {
-//			LM_ERR("could not find find CC App CDP session\n");
-//			return;
-//		}
-//
-//		cdpb.AAAStartChargingCCAccSession(cdp_session);
-//		cdpb.AAASessionsUnlock(cdp_session->hash);
-//	}
 
 	if (reply != FAKED_REPLY && reply->REPLY_STATUS == 200) {
 		LM_DBG("Call answered on dlg [%p] - search for Ro Session and initialise timers.\n", dlg);