[sr-dev] [tracker] Comment added: To tag parsing bug

[sip-router]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#465 - To tag parsing bug
User who did this - Daniel-Constantin Mierla (miconda)

----------
The next change is a bit unclear for me:

<code>
-					if (to_tag.len )
+					if ( to_tag.len || to_tag.s )
 						len+=new_tag->len-to_tag.len;
</code>

It is about computing the length of the response, but here it is not adding the new tag value length. However, in your description, you show that the tag value was added. My guess it that the patch could end up in a buffer overflow. At the first sight I would say that this change is not necessary, only the part on the parser.
----------

More information can be found at the following URL:
https://sip-router.org/tracker/index.php?do=details&task_id=465#comment1612

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.