[sr-dev] Offline message handling

[Daniel-Constantin Mierla]

Hello,

thanks for troubleshooting further. I pushed a different patch, as your 
suggestion was causing to go again from the beginning of sent list each 
time, until there was no more sent-ok message.

Can you try the patch from commit:

- 
http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5fd8a1bdaae82decdb606901fe7bf3e6e9149803

If all ok, I will backport.

Cheers,
Daniel

On 02/09/14 09:36, Bhupendra Singh wrote:
> Hello Folks,
>
> I found the root cause of this issue.
>
> In file ms_msg_list.c, issue is on line 290.
> (https://github.com/sipwise/kamailio/blob/master/modules/msilo/ms_msg_list.c)
>
>
> Line 290: p0 = p0->next;
>
> should be like this below :
>
> p0 = ml->lsent;
>
>
> The issue is p0->next becomes null in first iteration so it won't 
> process more than one element in 'while' loop. Hence this is the main 
> cause of slowness of message deletion.
> I have tested modified code and it works fine now.
>
> Develoerps,
> Please review this change and advise accordingly.
>
> Thanks
>
>
> On Mon, Aug 25, 2014 at 11:35 PM, Bhupendra Singh <bsingh at bsingh.net 
> <mailto:bsingh at bsingh.net>> wrote:
>
>     Hi Guys,
>
>     Has anyone used/using offline message handling and storage in
>     "silo" table?
>     My  issue is cleanup of stored message is taking very long time
>     specially when many messages are left for target users.
>     After further investigation I realized, only one message gets
>     deleted in one pass and next in next pass ( after 30 second
>     default timer).
>     Is it intentional ? How can we make sure that all delivered
>     messages get deleted right away for that user?
>
>     Thanks
>
>
>
>
>
> _______________________________________________
> sr-dev mailing list
> sr-dev at lists.sip-router.org
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

-- 
Daniel-Constantin Mierla
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
Next Kamailio Advanced Trainings 2014 - http://www.asipto.com
Sep 22-25, Berlin, Germany ::: Oct 15-17, San Francisco, USA

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20140902/6bc2f769/attachment.html>