[sr-dev] [tracker] Task opened: UAC table locking

[sip-router]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

A new Flyspray task has been opened.  Details are below. 

User who did this - Savolainen Dmitri (snen) 

Attached to Project - sip-router
Summary - UAC table locking
Task Type - Bug Report
Category - Module
Status - Unconfirmed
Assigned To - 
Operating System - All
Severity - High
Priority - Normal
Reported Version - Development
Due in Version - Undecided
Due Date - Undecided
Details - uac module locking talbe

<code>
[root at sw4 sbin]# ./kamcmd core.info
{
	version: kamailio 4.2.0
	id: 6d89d2 
	compiler: gcc 4.4.7
	compiled: 12:42:58 Oct 20 2014
	flags: STATS: Off, USE_TCP, USE_TLS, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, F_MALLOC, DBG_F_MALLOC, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES
}


[root at sw4 sbin]#  ./kamcmd uac.reg_info l_uuid s:000105656
{
	l_uuid: 000105656
	l_username: 000105656
	l_domain: sip.domain2.ru
	r_username: 000105656
	r_domain: sip.domain.com
	realm: sip.domain.com
	auth_username: 000105656
	auth_password: xxxxxxxx
	auth_proxy: sip:000105656 at sip.domain.com
	expires: 120
	flags: 4
	diff_expires: 1791
	timer_expires: 1413880593
}
[root at sw4 sbin]# ./kamcmd uac.reg_dump
^C
</code>

so only Ctrl+C release me from waiting
this patch can help
<code>
diff --git a/modules/uac/uac_reg.c b/modules/uac/uac_reg.c
index 9b2abef..bd4eabb 100644
--- a/modules/uac/uac_reg.c
+++ b/modules/uac/uac_reg.c
@@ -1572,6 +1572,7 @@ static void rpc_uac_reg_info(rpc_t* rpc, void* ctx)
                                        rpc->fault(ctx, 500, "Internal error adding item");
                                        return;
                                }
+                               lock_release(&_reg_htable->entries[i].lock);
                                return;
                        }
                        reg = reg->next;
</code>



More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=484

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.