[sr-dev] git:master: modules/ims_registrar_scscf: Added missing release_ucontact when processing notifies

[Richard Good]

Module: sip-router
Branch: master
Commit: 69ef30a2fcf0c3b5f50747a3e7cf2a9c02d358c3
URL:    http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=69ef30a2fcf0c3b5f50747a3e7cf2a9c02d358c3

Author: Richard Good <richard.good at smilecoms.com>
Committer: Richard Good <richard.good at smilecoms.com>
Date:   Tue Nov 25 11:59:56 2014 +0200

modules/ims_registrar_scscf: Added missing release_ucontact when processing notifies

---

 modules/ims_registrar_scscf/registrar_notify.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/modules/ims_registrar_scscf/registrar_notify.c b/modules/ims_registrar_scscf/registrar_notify.c
index 8638a4a..b751861 100644
--- a/modules/ims_registrar_scscf/registrar_notify.c
+++ b/modules/ims_registrar_scscf/registrar_notify.c
@@ -560,13 +560,16 @@ int process_contact(impurecord_t* presentity_impurecord, udomain_t * _d, int exp
 				if (ul.unlink_contact_from_impu(implicit_impurecord, ucontact, 1) != 0) {
 				    LM_ERR("Failed to delete ucontact <%.*s> from implicit IMPU\n", contact_uri.len, contact_uri.s);
 				    ul.unlock_contact_slot(&contact_uri);
+				    ul.release_ucontact(ucontact);
 				    goto next_implicit_impu;	//TODO: don't need to use goto here...
 				}
 				ul.unlock_contact_slot(&contact_uri);
 			}else {//state is active
 				LM_DBG("This contact: <%.*s> is not in state terminated and is in usrloc, ignore\n", contact_uri.len, contact_uri.s);
+				ul.release_ucontact(ucontact);
 				goto next_implicit_impu;
 			}
+			ul.release_ucontact(ucontact);
 		}
 next_implicit_impu:
 		ul.unlock_udomain(_d, &pi->public_identity);
@@ -593,13 +596,16 @@ next_implicit_impu:
 			    LM_ERR("Failed to delete ucontact <%.*s>\n", contact_uri.len, contact_uri.s);
 			    ret = CSCF_RETURN_FALSE;
     			    ul.unlock_contact_slot(&contact_uri);
+			    ul.release_ucontact(ucontact);
 			    goto done;
 			}
 			ul.unlock_contact_slot(&contact_uri);
 		}else {//state is active
 			LM_DBG("This contact: <%.*s> is not in state terminated and is in usrloc, ignore\n", contact_uri.len, contact_uri.s);
+			ul.release_ucontact(ucontact);
 			goto done;
 		}
+		ul.release_ucontact(ucontact);
 	}
 	
 done: