[sr-dev] git:master: Revert "dialog: Don't destroy dialogs in timer while they' re still being referenced"

Alex Hermann alex at speakup.nl
Tue Nov 4 14:28:27 CET 2014


Module: sip-router
Branch: master
Commit: e673771368c25a70c5b289435694df6e9880f969
URL:    http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e673771368c25a70c5b289435694df6e9880f969

Author: Alex Hermann <alex at speakup.nl>
Committer: Alex Hermann <alex at speakup.nl>
Date:   Tue Nov  4 14:24:46 2014 +0100

Revert "dialog: Don't destroy dialogs in timer while they're still being referenced"

This reverts commit 3eef4c8be5cc2b6ccba993a62f8c8039d1adf7da.

Reintroduces possible segfault in cleanup routine.

---

 modules/dialog/dlg_hash.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/modules/dialog/dlg_hash.c b/modules/dialog/dlg_hash.c
index 31ad428..09166b8 100644
--- a/modules/dialog/dlg_hash.c
+++ b/modules/dialog/dlg_hash.c
@@ -242,7 +242,7 @@ int dlg_clean_run(ticks_t ti)
 		while (dlg) {
 			tdlg = dlg;
 			dlg = dlg->next;
-			if(tdlg->state==DLG_STATE_UNCONFIRMED && tdlg->init_ts<tm-300 && tdlg->ref<=1) {
+			if(tdlg->state==DLG_STATE_UNCONFIRMED && tdlg->init_ts<tm-300) {
 				/* dialog in early state older than 5min */
 				LM_NOTICE("dialog in early state is too old (%p ref %d)\n",
 						tdlg, tdlg->ref);




More information about the sr-dev mailing list