[sr-dev] [tracker] Comment added: Crash in websocket module

[sip-router]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#406 - Crash in websocket module
User who did this - Hugh Waite (hugh.waite)

----------
I've had a look through this and it seems OK. I have the following comments.

In decode_and_validate_ws_frame, you have removed the 'close_connection' functions and used the status of the returned error text instead. Some of these cases used different websocket error codes, (1002, 1008, 1009) and this information is now lost.

In the new function wsconn_get_list, the size of the NULL terminated list should be (list_len + 1) * sizeof(ws_connection_t*).


----------

More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=406#comment1369

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.