[sr-dev] [tracker] Task opened: sca_call_info_update() function for 180 responses (Attachment added)

[sip-router]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

A new Flyspray task has been opened.  Details are below. 

User who did this - Joao Vitor Arruda (jarruda) 

Attached to Project - sip-router
Summary - sca_call_info_update() function for 180 responses
Task Type - Bug Report
Category - Module
Status - Unconfirmed
Assigned To - 
Operating System - All
Severity - High
Priority - Normal
Reported Version - 4.1
Due in Version - Undecided
Due Date - Undecided
Details - The actual code for sca_call_info_update() function in the SCA Module deal with 180 and 183 response codes in different ways:
https://github.com/kamailio/kamailio/blob/master/modules/sca/sca_call_info.c#L1073-L1080

 - For 180 responses it will produce a NOTIFY with "appearance-state=alerting";
 - For 183 responses it will produce a NOTIFY with "appearance-state=progressing";

Reading the attached "Broadworks SIP Access Side Extensions Interface Specifications, Release 13.0, version 1", which the module use as guide, it looks that both 180 and 183 should produce a NOTIFY with "appearance-state=progressing". 

This document says:
The defined states are:
.....
Progressing = This appearance on the line is currently making an outgoing call.
Alerting = This appearance is receiving an incoming call.
.....

So when processing 180 and 183 responses it should use the same appearance-state (progressing) as it is dealing with responses for an outgoing call.

It was noticed that using the "wrong" appearance-state (alerting) when processing 180 responses will lead to problems with Polycom phones using firmware version 4.0.3 as the phones upon receiving the wrong appearance-state will change the display from "To:CalledExtension" to "From:CalledExtension" and record the call in the "Received Calls" instead of "Placed Calls".

The attached patch was produced to fix the actual code.

One or more files have been attached.

More information can be found at the following URL:
https://sip-router.org/tracker/index.php?do=details&task_id=446

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.